Re: [PATCH] ACPI: APEI: EINJ: warn on invalid argument when explicitly indicated by platform

From: Rafael J. Wysocki
Date: Wed Mar 22 2023 - 12:53:33 EST


On Wed, Mar 22, 2023 at 5:13 PM Luck, Tony <tony.luck@xxxxxxxxx> wrote:
>
> > Fix to return -EINVAL in the __einj_error_inject() error handling case
> > instead of -EBUSY, when explicitly indicated by the platform in the status
> > of the completed operation.
>
> Needs a bit longer description on the use case based on follow up discussion.
> Key information is the EINVAL is an indicator to the user that the parameters they
> supplied cannot be used for injection.

Right.

So Shuai, please resend the patch with a more elaborate changelog.

> But for the code:
>
> Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>

And add the above tag to it when resending.