Re: [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name.

From: Randy Dunlap
Date: Wed Mar 22 2023 - 11:21:16 EST




On 3/22/23 01:51, Mirsad Goran Todorovac wrote:
> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell
> syntax error in certain paths of the script execution.
>

Fixes: 46dff8d7e381e ("scripts: merge_config: Add option to suppress warning on overrides")

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Cc: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> Cc: linux-kbuild@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@xxxxxxxxxxxx>
> ---
> scripts/kconfig/merge_config.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
> index 32620de473ad..902eb429b9db 100755
> --- a/scripts/kconfig/merge_config.sh
> +++ b/scripts/kconfig/merge_config.sh
> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
> NEW_VAL=$(grep -w $CFG $MERGE_FILE)
> BUILTIN_FLAG=false
> if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then
> - ${WARNOVVERIDE} Previous value: $PREV_VAL
> + ${WARNOVERRIDE} Previous value: $PREV_VAL
> ${WARNOVERRIDE} New value: $NEW_VAL
> ${WARNOVERRIDE} -y passed, will not demote y to m
> ${WARNOVERRIDE}

--
~Randy