Re: [PATCH V1 2/4] dt-bindings: soc: qcom,mpm-sleep-counter: Add the dtschema

[Souradeep Chowdhury]

On 3/21/2023 11:03 PM, Krzysztof Kozlowski wrote:
> On 21/03/2023 14:51, Souradeep Chowdhury wrote:
> > Add the device tree bindings for the module power manager sleep
> > counter.
> >
> > Signed-off-by: Souradeep Chowdhury <quic_schowdhu@xxxxxxxxxxx>
> > ---
> >   .../bindings/soc/qcom/qcom,mpm-sleep-counter.yaml  | 40 ++++++++++++++++++++++
> >   1 file changed, 40 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml
> > new file mode 100644
> > index 0000000..f9f46b7
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml
> > @@ -0,0 +1,40 @@
> > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/soc/qcom/qcom,mpm-sleep-counter.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MPM Sleep Counter
> > +
> > +maintainers:
> > +  - Souradeep Chowdhury <quic_schowdhu@xxxxxxxxxxx>
> > +
> > +description: |
> > +    MPM(Module Power Manager) has a sleep counter which is used to track
>
> Missing space:
> MPM (Module

Ack
> > +    various stages of the boot process in Qualcomm.
>
> in Qualcomm SoC. Because you do not track it in the company...

Ack
> > +
> > +properties:
> > +  compatible:
> > +    items:
>
> Drop items.

Ack
> > +      - const: qcom,mpm2-sleep-counter
>
> SoC specific compatible.

This is a generic Module Power Manager Sleep Counter which is present in 
all Qcom Socs, so SoC specific compatible is not given here.

> > +
> > +  reg:
> > +    items:
> > +      - description: MPM Sleep Counter Base
>
> just maxItems: 1

Ack
> > +
> > +  clock-frequency:
> > +    description: Frequency for the sleep counter
>
> Since this does not have clocks, what frequency you are setting here?

Module Power Manager(MPM) Sleep Counter is a clock that starts ticking 
from Primary Boot Loader(PBL) Stage. This is usually a 32 Khz clock and 
the frequency for the same is stored here.

> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    mpm2-sleep-counter@c221000{
>
> Node names should be generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Ack
> > +       compatible = "qcom,mpm2-sleep-counter";
> > +       reg = <0xc221000 0x1000>;
> > +       clock-frequency = <32768>;
> > +    };
>
> Best regards,
> Krzysztof