Re: [PATCH v3 1/4] dt-bindings: mfd: Add TI TPS6594 PMIC

[Julien Panis]

On 3/22/23 08:34, Krzysztof Kozlowski wrote:
> On 21/03/2023 18:10, Julien Panis wrote:
> > TPS6594 is a Power Management IC which provides regulators and others
> > features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
> > PFSM (Pre-configurable Finite State Machine) managing the state of the
> > device.
> > TPS6594 is the super-set device while TPS6593 and LP8764X are derivatives.
> >
> > Signed-off-by: Julien Panis <jpanis@xxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/mfd/ti,tps6594.yaml   | 231 ++++++++++++++++++
> >   1 file changed, 231 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/mfd/ti,tps6594.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml b/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml
> > new file mode 100644
> > index 000000000000..4e4565a68e40
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml
> > @@ -0,0 +1,231 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mfd/ti,tps6594.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: TI TPS6594 Power Management Integrated Circuit
> > +
> > +maintainers:
> > +  - Julien Panis <jpanis@xxxxxxxxxxxx>
> > +
> > +description:
> > +  TPS6594 is a Power Management IC which provides regulators and others
> > +  features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
> > +  PFSM (Pre-configurable Finite State Machine) managing the state of the device.
> > +  TPS6594 is the super-set device while TPS6593 and LP8764X are derivatives.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - ti,lp8764x
> Does x stand for a wildcard? If so, then fix it. Compatibles should be
> specific.

OK, I will remove 'x' in next version.

> > +      - ti,tps6593
> > +      - ti,tps6594
> > +
> > +  reg:
> > +    description: I2C slave address or SPI chip select number.
> > +    maxItems: 1
> > +
> > +  ti,primary-pmic:
> > +    type: boolean
> > +    description: |
> > +      Identify the primary PMIC on SPMI bus.
> > +      A multi-PMIC synchronization scheme is implemented in the PMIC device
> > +      to synchronize the power state changes with other PMIC devices. This is
> > +      accomplished through a SPMI bus: the primary PMIC is the controller
> > +      device on the SPMI bus, and the secondary PMICs are the target devices
> > +      on the SPMI bus.
> > +
> > +  system-power-controller: true
> > +
> > +  gpio-controller: true
> > +
> > +  '#gpio-cells':
> > +    const: 2
> > +    description: |
> > +      The first cell is the pin number, the second cell is used to specify flags.
> > +      See ../gpio/gpio.txt for more information.
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  ti,multi-phase-id:
> > +    description: |
> > +      Describes buck multi-phase configuration, if any. For instance, XY id means
> > +      that outputs of buck converters X and Y are combined in multi-phase mode.
> > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> No improvements here. As Rob pointed out, this looks like coupled
> regulators.

I used 'oneOf' logic to handle mutual exclusion. But it seems that I did not
understand what you and Rob expected.
Does some generic property already exist for 'coupled regulators' ?

> Best regards,
> Krzysztof