Re: [PATCH] init/initramfs: Fix argument forwarding to panic() in panic_show_mem()

From: Andrew Donnellan
Date: Wed Mar 22 2023 - 01:29:29 EST


On Tue, 2023-03-21 at 10:05 +1100, Benjamin Gray wrote:
> Forwarding variadic argument lists can't be done by passing a va_list
> to a function with signature foo(...) (as panic() has). It ends up
> interpreting the va_list itself as a single argument instead of
> iterating it. printf() happily accepts it of course, leading to
> corrupt
> output.
>
> Convert panic_show_mem() to a macro to allow forwarding the
> arguments.
> The function is trivial enough that it's easier than trying to
> introduce
> a vpanic() variant.
>
> Signed-off-by: Benjamin Gray <bgray@xxxxxxxxxxxxx>

Reviewed-by: Andrew Donnellan <ajd@xxxxxxxxxxxxx>

--
Andrew Donnellan OzLabs, ADL Canberra
ajd@xxxxxxxxxxxxx IBM Australia Limited