Re: [PATCH RESEND] EDAC/altera: Remove redundant error logging

From: Borislav Petkov
Date: Tue Mar 21 2023 - 19:22:02 EST


On Thu, Mar 02, 2023 at 12:43:31AM +0530, Deepak R Varma wrote:
> A call to platform_get_irq() already prints an error on failure within
> its own implementation. So printing another error based on its return
> value in the caller is redundant and should be removed. The clean up
> also makes if condition block braces unnecessary. Remove that as well.
>
> Issue identified using platform_get_irq.cocci coccinelle semantic patch.
>
> Signed-off-by: Deepak R Varma <drv@xxxxxxxxx>
> ---
> Note:
> The change was compile tested only.
> Resending the patch for a review and feedback.
>
> drivers/edac/altera_edac.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)

Applied, thanks.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette