Re: [PATCH] staging: greybus: remove camel case

From: Khadija Kamran
Date: Tue Mar 21 2023 - 12:41:27 EST


On Tue, Mar 21, 2023 at 07:11:22AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Mar 20, 2023 at 09:53:42PM +0500, Khadija Kamran wrote:
> > Several variables and functions were named Camel Case. This resulted in
> > checks pointed by checkpatch.pl
> >
> > Avoid camel case by changing names.
> >
> > Signed-off-by: Khadija Kamran <kamrankhadijadj@xxxxxxxxx>
> > ---
> > drivers/staging/iio/addac/adt7316.c | 64 ++++++++++++++---------------
>
> This has nothing to do with "greybus" :(
>

Hi Greg!

I am sorry about making a really silly mistake here.
I will try not to make a mistake like this again.

> > 1 file changed, 32 insertions(+), 32 deletions(-)
> >
> > diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> > index 79467f056a05..49702beeac30 100644
> > --- a/drivers/staging/iio/addac/adt7316.c
> > +++ b/drivers/staging/iio/addac/adt7316.c
> > @@ -672,7 +672,7 @@ static IIO_DEVICE_ATTR(da_high_resolution, 0644,
> > adt7316_store_da_high_resolution,
> > 0);
> >
> > -static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,
> > +static ssize_t adt7316_show_AIN_internal_vref(struct device *dev,
>
> "Vref" is correct, please keep it as is.
>

Okay understood.
Thank you.

Regards,
Khadija


> thanks,
>
> greg k-h