Re: [PATCH net-next] smsc911x: remove superfluous variable init

From: Wolfram Sang
Date: Tue Mar 21 2023 - 10:38:42 EST



> > struct smsc911x_data *pdata = netdev_priv(dev);
> > - struct phy_device *phydev = NULL;
> > + struct phy_device *phydev;
> > int ret;
> >
> > phydev = phy_find_first(pdata->mii_bus);
>
> Nit: perhaps combine this assignment with the variable declaration?

I thought about it but found this version to be easier readable.

Thanks!

Attachment: signature.asc
Description: PGP signature