Re: [PATCH 4/4] Staging: rtl8712: osdep_intf: Improve RND4 macro for better debugging and safety

From: Dan Carpenter
Date: Tue Mar 21 2023 - 10:16:36 EST


On Tue, Mar 21, 2023 at 05:11:41PM +0530, Inshal Khan wrote:
> drivers/staging/rtl8712/osdep_intf.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/osdep_intf.h b/drivers/staging/rtl8712/osdep_intf.h
> index 95a21f380cd7..0e097b4a8670 100644
> --- a/drivers/staging/rtl8712/osdep_intf.h
> +++ b/drivers/staging/rtl8712/osdep_intf.h
> @@ -18,8 +18,8 @@
> #include "drv_types.h"
>
> #define RND4(x) ({ \
> - typeof(x) _x = (x); \
> - (((_x) + 3) & ~3); \
> + typeof(x) _x = (x); \
> + (((_x) + 3) & ~3); \

Just use normal kernel rounding macros and delete RND4().

regards,
dan carpenter