Re: [PATCH 6/7 v5] sh: fix Kconfig entry for NUMA => SMP

[Geert Uytterhoeven]

Hi Adrian,

On Tue, Mar 21, 2023 at 9:45 AM John Paul Adrian Glaubitz
<glaubitz@xxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, 2023-03-21 at 09:42 +0100, Geert Uytterhoeven wrote:
> > On Tue, Mar 21, 2023 at 9:10 AM John Paul Adrian Glaubitz
> > <glaubitz@xxxxxxxxxxxxxxxxxxx> wrote:
> > > On Tue, 2023-03-21 at 08:55 +0100, Geert Uytterhoeven wrote:
> > > > On Tue, Mar 21, 2023 at 12:13 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> > > > > Fix SUPERH builds that select SYS_SUPPORTS_NUMA but do not select
> > > > > SYS_SUPPORTS_SMP and SMP.
> > > >
> > > > Perhaps because these SoCs do not support SMP?
> > >
> > > Well, there is actually a dual-core 7786 board available, see:
> > >
> > > > https://www.apnet.co.jp/product/superh/ap-sh4ad-0a.html
> > >
> > > Quoting:
> > >
> > > »The SH7786 is equipped with a dual-core SH-4A and has interfaces such as
> > >  DDR3 SDRAM, PCI Express, USB, and display unit.«
> >
> > SH7786 is dual-core...
> >
> > > FWIW, I just realized we need this for config CPU_SUBTYPE_SH7786 as well.
> >
> > ... and CPU_SUBTYPE_SH7786 selects CPU_SHX3, which selects
> > SYS_SUPPORTS_SMP and SYS_SUPPORTS_NUMA in turn.
> > So everything is fine for SH7786.
>
> Yeah, this explains it then. Your new patch is definitely the better approach
> and I would prefer it over Randy's suggested change. Let's see what the mm
> maintainers have to say.

I'm sure the missed condition was just an oversight, so I expect no
objections.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds