Re: [PATCH 20/28] media: platform: jpeg: always reference OF data

From: Krzysztof Kozlowski
Date: Tue Mar 21 2023 - 04:21:58 EST


On 21/03/2023 09:11, Arnd Bergmann wrote:
> On Sun, Mar 12, 2023, at 14:13, Krzysztof Kozlowski wrote:
>> The driver can match only via the DT table so the table should be always
>> used and the of_match_ptr does not have any sense (this also allows ACPI
>> matching via PRP0001, even though it might not be relevant here). This
>> also fixes !CONFIG_OF error:
>>
>> drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c:1890:38: error:
>> ‘mtk8195_jpegdec_drvdata’ defined but not used
>> [-Werror=unused-const-variable=]
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> I see now that we both submitted the same patch, but now Hans

We as you and me? I cannot find your patch on lore:
https://lore.kernel.org/all/?q=f%3Aarnd%40arndb.de

> merged a worse fix [1] without a changelog text.
>
> Arnd
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=4ae47770d57bff01

Uh, I can rebase my patchset.

Best regards,
Krzysztof