Re: [PATCH v2 net] net/sonic: use dma_mapping_error() for error check

From: Leon Romanovsky
Date: Tue Mar 21 2023 - 04:19:17 EST


On Tue, Mar 21, 2023 at 02:45:43PM +1100, Finn Thain wrote:
> From: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>
>
> The DMA address returned by dma_map_single() should be checked with
> dma_mapping_error(). Fix it accordingly.
>
> Fixes: efcce839360f ("[PATCH] macsonic/jazzsonic network drivers update")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>
> Tested-by: Stan Johnson <userm57@xxxxxxxxx>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxx>
> ---
> This was originally Zhang Changzhong's patch. I've just added the missing
> curly bracket which caused a build failure when the patch was first posted.
> ---
> drivers/net/ethernet/natsemi/sonic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>