Re: [PATCH] crypto: caam: Clear some memory in instantiate_rng()

From: Herbert Xu
Date: Mon Mar 20 2023 - 23:27:09 EST


On Tue, Mar 21, 2023 at 12:45:43AM +0100, Christophe JAILLET wrote:
> According to the comment at the end of the 'for' loop just a few lines
> below, it looks needed to clear 'desc'.
>
> So it should also be cleared for the first iteration.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> This patch is speculative, but can't hurt.
>
> Maybe the memset() at the end of the 'for' loop could be removed instead.

I think the memset can be removed. Horia?
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt