Re: [PATCH v2 00/12] Reviving the Proxy Execution Series v2

From: John Stultz
Date: Mon Mar 20 2023 - 22:51:19 EST


On Mon, Mar 20, 2023 at 4:37 PM John Stultz <jstultz@xxxxxxxxxx> wrote:
> Changes since Connor’s last submission:
> ---------------------------------------
> * I dropped the patch changing mutex::wait_lock to always save/restore irq
> flags (as Joel raised a concern that the patch wasn’t actually
> necessary).

Well, despite a bit of testing prior, it is of course immediately
after sending it I managed to trip lockdep to get a warning on this
(though it tripped on the blocked_lock not the wait_lock), so I'll be
re-adding that patch (or a variant) back in in the next series.

[ 1.351993] CPU0 CPU1
[ 1.351993] ---- ----
[ 1.351993] lock(&p->blocked_lock);
[ 1.351993] local_irq_disable();
[ 1.351993] lock(&rq->__lock);
[ 1.351993] lock(&p->blocked_lock);
[ 1.351993] <Interrupt>
[ 1.351993] lock(&rq->__lock);

thanks
-john