Re: [PATCH v9 1/5] vfio/migration: Add debugfs to live migration driver

From: liulongfang
Date: Mon Mar 20 2023 - 22:21:48 EST


On 2023/3/21 5:42, Jason Gunthorpe wrote:
> On Mon, Mar 20, 2023 at 03:33:36PM -0600, Alex Williamson wrote:
>
>> This would allow that mlx5 and future drivers automatically get this
>> with no driver code, and in fact all devices would get debugfs dev_name
>> directories for better test coverage. hisi_acc would only need to add
>> driver specific entries after registering the device and free any
>> related data after unregistering the device. In this way, none of the
>> entry points here would need to be exported for drivers, which is
>> perhaps the direction Jason was thinking with his prior comments.
>
> Yes, my point was more not to add more ops specifically to wrapper
> debugfs stuff. If drivers want a special debugfs file then there is
> lots of infrastructure to just create that off a common point
>

OK! I understand what you and Alex are asking for.
I will re-debug a version based on your request.

Thanks.
Longfang.
> Jason
> .
>