Re: [PATCH v2 1/2] mfd: tps6586x: use devm-based power off handler

[Dmitry Osipenko]

On 3/21/23 01:03, Benjamin Bara wrote:
> +static int tps6586x_power_off_handler(struct sys_off_data *data)
>  {
> -	if (tps6586x_clr_bits(tps6586x_dev, TPS6586X_SUPPLYENE, EXITSLREQ_BIT))
> -		return;
> +	int ret;

Nit: "int ret" should be put after "struct tps6586x_dev" to adhere
canonical kernel coding style

> +	struct device *tps6586x_dev = (struct device *)data->cb_data;

No need for casting of the void* type

-- 
Best regards,
Dmitry