RE: [PATCH v5 04/34] x86/traps: add external_interrupt() to dispatch external interrupts

From: Li, Xin3
Date: Mon Mar 20 2023 - 19:49:47 EST


> > > + if (sysvec < NR_SYSTEM_VECTORS) {
> > > + if (system_interrupt_handlers[sysvec])
> > > + system_interrupt_handlers[sysvec](regs);
> > > + else
> > > + dispatch_spurious_interrupt(regs, vector);
> >
> > ISTR suggesting you can get rid of this branch if you stuff
> > system_interrupt_handlers[] with dispatch_spurious_interrupt instead
> > of NULL.
>
> Ah, I suggested that for another function vector, but it applies here too I suppose :-)

Of course!

We just need to use a wrapper as dispatch_spurious_interrupt() takes an extra
parameter "vector".

Thanks!
Xin