[PATCH] f2fs: remove else in f2fs_write_cache_pages()

From: Yangtao Li
Date: Mon Mar 20 2023 - 13:37:03 EST


As Christoph Hellwig point out:

Please avoid the else by doing the goto in the branch.

Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
---
fs/f2fs/data.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index bf51e6e4eb64..fa931fb768e7 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -3123,12 +3123,9 @@ static int f2fs_write_cache_pages(struct address_space *mapping,
}

if (folio_test_writeback(folio)) {
- if (wbc->sync_mode != WB_SYNC_NONE)
- f2fs_wait_on_page_writeback(
- &folio->page,
- DATA, true, true);
- else
+ if (wbc->sync_mode == WB_SYNC_NONE)
goto continue_unlock;
+ f2fs_wait_on_page_writeback(&folio->page, DATA, true, true);
}

if (!folio_clear_dirty_for_io(folio))
--
2.35.1