Re: [PATCH v4 09/12] arm64: dts: qcom: sm8350-hdk: add pmic glink node

[Neil Armstrong]

On 18/03/2023 15:00, Konrad Dybcio wrote:
> On 17.03.2023 16:04, Neil Armstrong wrote:
> > Add the pmic glink node linked with the DWC3 USB controller
> > switched to OTG mode and tagged with usb-role-switch.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
>
> [...]
>
> >   &usb_1_dwc3 {
> > -	/* TODO: Define USB-C connector properly */
> > -	dr_mode = "peripheral";
> > +	dr_mode = "otg";
> > +	usb-role-switch;
> > +
> > +	ports {
> You created these in patch [6/12]!

Damn!

Thx!

Neil

> Konrad
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		port@0 {
> > +			reg = <0>;
> > +
> > +			usb_1_dwc3_hs: endpoint {
> > +				remote-endpoint = <&pmic_glink_hs_in>;
> > +			};
> > +		};
> > +
> > +		port@1 {
> > +			reg = <1>;
> > +
> > +			usb_1_dwc3_ss: endpoint {
> > +				remote-endpoint = <&pmic_glink_ss_in>;
> > +			};
> > +		};
> > +	};
> > +};
> > +
> > +&usb_1_dwc3_hs {
> > +	remote-endpoint = <&pmic_glink_hs_in>;
> > +};
> > +
> > +&usb_1_dwc3_ss {
> > +	remote-endpoint = <&pmic_glink_ss_in>;
> >   };
> >   
> >   &usb_1_hsphy {