Re: [PATCH] iio: addac: stx104: Migrate to the regmap API

[William Breathitt Gray]

On Mon, Mar 20, 2023 at 05:51:32PM +0200, Andy Shevchenko wrote:
> On Sun, Mar 19, 2023 at 04:22:56PM -0400, William Breathitt Gray wrote:
> > The regmap API supports IO port accessors so we can take advantage of
> > regmap abstractions rather than handling access to the device registers
> > directly in the driver.
> 
> ...
> 
> > -/**
> > - * struct stx104_iio - IIO device private data structure
> 
> I believe this...
> 
> > - * @chan_out_states:	channels' output states
> > - * @reg:		I/O address offset for the device registers
> > - */
> 
> > -struct stx104_iio {
> 
> ...and this can be left here. With that the diff won't be too disrupted.

You're right Andy, I'll adjust this in v2 so the diff becomes clearer
(along with some bitfield API adjustments).

William Breathitt Gray

Attachment: signature.asc
Description: PGP signature