Re: [PATCH v1] net/iucv: Remove redundant driver match function

From: Alex Williamson
Date: Mon Mar 20 2023 - 12:30:15 EST


On Sun, 19 Mar 2023 21:16:31 +0100
Heiko Carstens <hca@xxxxxxxxxxxxx> wrote:

> On Sun, Mar 19, 2023 at 01:08:40PM +0800, Lizhe wrote:
> > If there is no driver match function, the driver core assumes that each
> > candidate pair (driver, device) matches, see driver_match_device().
> >
> > Drop the bus's match function that always returned 1 and so
> > implements the same behaviour as when there is no match function
> ...
> >
> > Signed-off-by: Lizhe <sensor1010@xxxxxxx>
> > ---
> > net/iucv/iucv.c | 6 ------
> > 1 file changed, 6 deletions(-)
> ...
> > -static int iucv_bus_match(struct device *dev, struct device_driver *drv)
> > -{
> > - return 0;
> ^^^^^^^^
>
> If I'm not wrong then 0 != 1.
>

Seems like an unchecked patch bot, proposed an identical bad patch for
vfio/mdev. Thanks,

Alex