Re: [PATCH v2 0/2] regmap-irq: Drop map from handle_mask_sync() parameters

[William Breathitt Gray]

On Mon, Mar 20, 2023 at 02:44:43PM +0200, Andy Shevchenko wrote:
> On Sun, Mar 19, 2023 at 05:02:00PM -0400, William Breathitt Gray wrote:
> > Changes in v2:
> >  - Pull out 104-dio-48e refactor to a precursor patch
> > 
> > Remove the map parameter from the struct regmap_irq_chip callback
> > handle_mask_sync() because it can be passed via the irq_drv_data
> > parameter instead. The gpio-104-dio-48e driver is the only consumer of
> > this callback and is thus updated accordingly.
> > 
> > A couple pending patchsets also utilize handle_mask_sync() [0][1], so
> > it'll be useful to merge the changes in this series first to avoid
> > subsequent noise adjusting the dependent drivers.
> > 
> > [0] https://lore.kernel.org/r/cover.1677515341.git.william.gray@xxxxxxxxxx/
> > [1] https://lore.kernel.org/r/cover.1678106722.git.william.gray@xxxxxxxxxx/
> 
> Good idea and intention, but something went wrong with bisectability as pointed
> out by the build bot. As a last resort you would need to squash these two, but
> try first another possible patch series split.
> 
> -- 
> With Best Regards,
> Andy Shevchenko

I should have build tested each commit when I rebased rather than just
the last. I'd rather avoid a squash so that these changes are distinct
for the sake of a clear git history on the regmap API change; I'll
submit a v3 soon with the minor changes needed.

William Breathitt Gray

Attachment: signature.asc
Description: PGP signature