Re: [PATCH v2 2/2] spi: loongson: add bus driver for the loongson spi controller

From: Mark Brown
Date: Mon Mar 20 2023 - 08:54:02 EST


On Sat, Mar 18, 2023 at 02:07:16PM +0800, zhuyinbo wrote:
> 在 2023/3/18 上午12:26, Mark Brown 写道:
> > On Fri, Mar 17, 2023 at 04:29:50PM +0800, Yinbo Zhu wrote:

> > As IIRC I mentioned last time setup() might be called while other
> > transfers are happening and therefore shouldn't affect parallel
> > operations on other devices.

> I think add spin_lock in  transfer_one interface that should be to fix this
> issue, Do you think so?

No, that doesn't help if setup() reconfigures the controller while it's
doing a transfer. The issue is that the controller might be put into
the wrong mode or run at the wrong speed.

Attachment: signature.asc
Description: PGP signature