Re: [PATCH] can: usb: f81604: add Fintek F81604 support

[Steen.Hegelund]

Hi Peter,

Besides what Michal has mentioned, I noted this:

On Fri Mar 17, 2023 at 10:33 AM CET, Ji-Ze Hong (Peter Hong) wrote:
> [Some people who received this message don't often get email from peter_hong@xxxxxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> This patch add support for Fintek USB to 2CAN controller support.
>
> Signed-off-by: Ji-Ze Hong (Peter Hong) <peter_hong@xxxxxxxxxxxxx>
> ---

..snip...

> +static int f81604_prepare_urbs(struct net_device *netdev)
> +{
> +       static u8 bulk_in_addr[F81604_MAX_DEV] = { 0x82, 0x84 };
> +       static u8 bulk_out_addr[F81604_MAX_DEV] = { 0x01, 0x03 };
> +       static u8 int_in_addr[F81604_MAX_DEV] = { 0x81, 0x83 };

These 3 should be made const

> +       struct f81604_port_priv *priv;
> +       int id;

..snip...

> +       int i;
> +MODULE_AUTHOR("Ji-Ze Hong (Peter Hong) <peter_hong@xxxxxxxxxxxxx>");
> +MODULE_DESCRIPTION("Fintek F81604 USB to 2xCANBUS");
> +MODULE_LICENSE("GPL");
> --
> 2.17.1


BR
Steen