Re: [PATCH] pinctrl: amd: Disable and mask interrupts on resume

[Linus Walleij]

On Mon, Mar 20, 2023 at 10:33 AM Kornel Dulęba <korneld@xxxxxxxxxxxx> wrote:

> This fixes a similar problem to the one observed in:
> commit 4e5a04be88fe ("pinctrl: amd: disable and mask interrupts on probe").
>
> On some systems, during suspend/resume cycle firmware leaves
> an interrupt enabled on a pin that is not used by the kernel.
> This confuses the AMD pinctrl driver and causes spurious interrupts.
>
> The driver already has logic to detect if a pin is used by the kernel.
> Leverage it to re-initialize interrupt fields of a pin only if it's not
> used by us.
>
> Signed-off-by: Kornel Dulęba <korneld@xxxxxxxxxxxx>

Uh oh this looks serious.
Do we need a Fixes: tag and Cc: stable on this patch?

Yours,
Linus Walleij