Re: [PATCH v3] input: alps: fix compatibility with -funsigned-char

From: Dmitry Torokhov
Date: Mon Mar 20 2023 - 02:04:07 EST


On Mon, Mar 20, 2023 at 05:52:29AM +0100, msizanoen1 wrote:
> From: msizanoen <msizanoen@xxxxxxxxxxx>
>
> The AlpsPS/2 code previously relied on the assumption that `char` is a
> signed type, which was true on x86 platforms (the only place where this
> driver is used) before kernel 6.2. However, on 6.2 and later, this
> assumption is broken due to the introduction of -funsigned-char as a new
> global compiler flag.
>
> Fix this by explicitly specifying the signedness of `char` when sign
> extending the values received from the device.
>
> v2:
> Add explicit signedness to more places
>
> v3:
> Use `s8` instead of `signed char`
>
> Fixes: f3f33c677699 ("Input: alps - Rushmore and v7 resolution support")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: msizanoen <msizanoen@xxxxxxxxxxx>

Applied, thank you.

--
Dmitry