RE: [PATCH] workqueue: Introduce show_freeze_workqueues_busy

[Jungseung Lee]

Hi, Tejun

>-----Original Message-----
>From: Tejun Heo <htejun@xxxxxxxxx> On Behalf Of Tejun Heo
>Sent: Saturday, March 18, 2023 7:16 AM
>To: Jungseung Lee <js07.lee@xxxxxxxxxxx>
>Cc: Lai Jiangshan <jiangshanlai@xxxxxxxxx>; Rafael J. Wysocki
><rafael@xxxxxxxxxx>; Pavel Machek <pavel@xxxxxx>; Len Brown
><len.brown@xxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; linux-
>pm@xxxxxxxxxxxxxxx; bw365.lee@xxxxxxxxxxx; yw85.kim@xxxxxxxxxxx;
>huijin.park@xxxxxxxxxxx
>Subject: Re: [PATCH] workqueue: Introduce show_freeze_workqueues_busy
>
>Hello,
>
>A few nits.
>
>On Wed, Mar 15, 2023 at 09:45:57PM +0900, Jungseung Lee wrote:
>> diff --git a/kernel/power/process.c b/kernel/power/process.c index
>> 6c1c7e5..590550f 100644
>> --- a/kernel/power/process.c
>> +++ b/kernel/power/process.c
>> @@ -93,7 +93,7 @@ static int try_to_freeze_tasks(bool user_only)
>>  		       todo - wq_busy, wq_busy);
>>
>>  		if (wq_busy)
>> -			show_all_workqueues();
>> +			show_freeze_workqueues_busy();
>
>Maybe name this show_freezable_workqueues()?
>
>> @@ -5043,7 +5043,7 @@ static void show_one_worker_pool(struct
>> worker_pool *pool)
>>  /**
>>   * show_all_workqueues - dump workqueue state
>>   *
>> - * Called from a sysrq handler or try_to_freeze_tasks() and prints
>> out
>> + * Called from a sysrq handler and prints out
>>   * all busy workqueues and pools.
>
>Can you reflow the comment to 80-col?
>
>> +/**
>> + * show_freeze_workqueues_busy - dump freezable workqueue state
>> + *
>> + * Called from try_to_freeze_tasks() and prints out
>> + * all freezable workqueues still busy.
>
>Ditto.
>

Thank you for the review and I will send a new patch including what you
mentioned soon

Thanks,

>Thanks.
>
>--
>tejun