Re: [PATCH v5 2/2] optee: add per cpu asynchronous notification
From: kernel test robot
Date: Sat Mar 18 2023 - 13:03:59 EST
Hi Etienne,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on soc/for-next]
[also build test WARNING on robh/for-next krzk-dt/for-next linus/master v6.3-rc2 next-20230317]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Etienne-Carriere/optee-add-per-cpu-asynchronous-notification/20230318-013004
base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
patch link: https://lore.kernel.org/r/20230317172859.989650-2-etienne.carriere%40linaro.org
patch subject: [PATCH v5 2/2] optee: add per cpu asynchronous notification
config: arm64-randconfig-s053-20230312 (https://download.01.org/0day-ci/archive/20230319/202303190039.RsU7kCIu-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://github.com/intel-lab-lkp/linux/commit/58552ace9e840f772ba5cb7d4694e332c74802e8
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Etienne-Carriere/optee-add-per-cpu-asynchronous-notification/20230318-013004
git checkout 58552ace9e840f772ba5cb7d4694e332c74802e8
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/firmware/smccc/ drivers/tee/optee/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202303190039.RsU7kCIu-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
>> drivers/tee/optee/smc_abi.c:1068:45: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct optee_pcpu [noderef] __percpu *pcpu @@ got struct optee_pcpu * @@
drivers/tee/optee/smc_abi.c:1068:45: sparse: expected struct optee_pcpu [noderef] __percpu *pcpu
drivers/tee/optee/smc_abi.c:1068:45: sparse: got struct optee_pcpu *
>> drivers/tee/optee/smc_abi.c:1097:49: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct optee_pcpu [noderef] __percpu *p @@ got struct optee_pcpu * @@
drivers/tee/optee/smc_abi.c:1097:49: sparse: expected struct optee_pcpu [noderef] __percpu *p
drivers/tee/optee/smc_abi.c:1097:49: sparse: got struct optee_pcpu *
>> drivers/tee/optee/smc_abi.c:1069:31: sparse: sparse: dereference of noderef expression
drivers/tee/optee/smc_abi.c:1099:17: sparse: sparse: dereference of noderef expression
vim +1068 drivers/tee/optee/smc_abi.c
1065
1066 static irqreturn_t notif_pcpu_irq_handler(int irq, void *dev_id)
1067 {
> 1068 struct optee_pcpu __percpu *pcpu = (struct optee_pcpu *)dev_id;
> 1069 struct optee *optee = pcpu->optee;
1070
1071 if (irq_handler(optee) == IRQ_WAKE_THREAD)
1072 queue_work(optee->smc.notif_pcpu_wq,
1073 &optee->smc.notif_pcpu_work);
1074
1075 return IRQ_HANDLED;
1076 }
1077
1078 static void notif_pcpu_irq_work_fn(struct work_struct *work)
1079 {
1080 struct optee_smc *optee_smc = container_of(work, struct optee_smc,
1081 notif_pcpu_work);
1082 struct optee *optee = container_of(optee_smc, struct optee, smc);
1083
1084 optee_smc_do_bottom_half(optee->ctx);
1085 }
1086
1087 static int init_pcpu_irq(struct optee *optee, u_int irq)
1088 {
1089 struct optee_pcpu __percpu *optee_pcpu;
1090 int cpu, rc;
1091
1092 optee_pcpu = alloc_percpu(struct optee_pcpu);
1093 if (!optee_pcpu)
1094 return -ENOMEM;
1095
1096 for_each_present_cpu(cpu) {
> 1097 struct optee_pcpu __percpu *p = per_cpu_ptr(optee_pcpu, cpu);
1098
1099 p->optee = optee;
1100 }
1101
1102 rc = request_percpu_irq(irq, notif_pcpu_irq_handler,
1103 "optee_pcpu_notification", optee_pcpu);
1104 if (rc)
1105 goto err_free_pcpu;
1106
1107 INIT_WORK(&optee->smc.notif_pcpu_work, notif_pcpu_irq_work_fn);
1108 optee->smc.notif_pcpu_wq = create_workqueue("optee_pcpu_notification");
1109 if (!optee->smc.notif_pcpu_wq) {
1110 rc = -EINVAL;
1111 goto err_free_pcpu_irq;
1112 }
1113
1114 optee->smc.optee_pcpu = optee_pcpu;
1115 optee->smc.notif_irq = irq;
1116
1117 pcpu_irq_num = irq;
1118 rc = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "optee/pcpu-notif:starting",
1119 optee_cpuhp_enable_pcpu_irq,
1120 optee_cpuhp_disable_pcpu_irq);
1121 if (!rc)
1122 rc = -EINVAL;
1123 if (rc < 0)
1124 goto err_free_pcpu_irq;
1125
1126 optee->smc.notif_cpuhp_state = rc;
1127
1128 return 0;
1129
1130 err_free_pcpu_irq:
1131 free_percpu_irq(irq, optee_pcpu);
1132 err_free_pcpu:
1133 free_percpu(optee_pcpu);
1134
1135 return rc;
1136 }
1137
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests