Re: [PATCH 2/2] memcg: do not drain charge pcp caches on remote isolated cpus

From: Michal Hocko
Date: Sat Mar 18 2023 - 04:04:26 EST


On Fri 17-03-23 16:32:29, Andrew Morton wrote:
> On Sat, 18 Mar 2023 06:22:40 +0800 kernel test robot <lkp@xxxxxxxxx> wrote:
>
> > mm/memcontrol.c: In function 'drain_all_stock':
> > >> mm/memcontrol.c:2369:35: error: implicit declaration of function 'cpu_is_isolated' [-Werror=implicit-function-declaration]
> > 2369 | else if (!cpu_is_isolated(cpu))
> > | ^~~~~~~~~~~~~~~
>
> Thanks.
>
> --- a/mm/memcontrol.c~memcg-do-not-drain-charge-pcp-caches-on-remote-isolated-cpus-fix
> +++ a/mm/memcontrol.c
> @@ -63,6 +63,7 @@
> #include <linux/resume_user_mode.h>
> #include <linux/psi.h>
> #include <linux/seq_buf.h>
> +#include <linux/sched/isolation.h>
> #include "internal.h"
> #include <net/sock.h>
> #include <net/ip.h>

Thanks a lot Andrew!
> _

--
Michal Hocko
SUSE Labs