[PATCH v2 1/2] dmaengine: ti: add null check of devm_kasprintf in udma_probe

From: void0red
Date: Sat Mar 18 2023 - 02:23:10 EST


From: Kang Chen <void0red@xxxxxxxxx>

devm_kasprintf may fails, uc->name might be null and wrong irq
name will be used in request.

Fixes: 25dcb5dd7b7c ("dmaengine: ti: New driver for K3 UDMA")
Acked-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx>
Reviewed-by: Vinod Koul <vkoul@xxxxxxxxxx>
Signed-off-by: Kang Chen <void0red@xxxxxxxxx>
---
v2 -> v1: split into two patches and add some tags

drivers/dma/ti/k3-udma.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index 7e23a6fdef95..692d1d25c70a 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -5494,6 +5494,8 @@ static int udma_probe(struct platform_device *pdev)
uc->config.dir = DMA_MEM_TO_MEM;
uc->name = devm_kasprintf(dev, GFP_KERNEL, "%s chan%d",
dev_name(dev), i);
+ if (!uc->name)
+ return -ENOMEM;

vchan_init(&uc->vc, &ud->ddev);
/* Use custom vchan completion handling */
--
2.34.1