Re: [PATCH v2] staging: sm750: Rename function to avoid CamelCase

From: Ira Weiny
Date: Sat Mar 18 2023 - 01:14:40 EST


Bagas Sanjaya wrote:
> On Wed, Mar 15, 2023 at 11:35:37PM +0800, Kloudifold wrote:
> > Subject: [PATCH v2] staging: sm750: Rename functions from CamelCase to snake case
>
> If I only see the subject above, which functions are renamed? I have
> to see the actual diff if the patch description doesn't answer that.
> In this case, I think the proper subject would be `[PATCH v3] staging:
> sm750: Rename sm750_hw_cursor_* functions to snake_case`.

No. The oneliner is a brief overview.

It is perfectly appropriate to have to look at the diff to see what was
done. The commit message is to state what the problem was and how it was
fixed.

Ira