Re: [PATCH 1/5] dmaengine: dw-axi-dmac: Don't set chancnt

From: Vinod Koul
Date: Fri Mar 17 2023 - 13:39:58 EST


On 14-03-23, 01:02, Jisheng Zhang wrote:
> The dma framework will calculate the dma channels chancnt, setting it

The dmaengine framework...

> outself is wrong.

s/outself/ourself

Looks this this is needed for all the patches

>
> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx>
> ---
> drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> index 4169e1d7d5ca..7f3a60e28e38 100644
> --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> @@ -1445,7 +1445,6 @@ static int dw_probe(struct platform_device *pdev)
> dma_cap_set(DMA_CYCLIC, dw->dma.cap_mask);
>
> /* DMA capabilities */
> - dw->dma.chancnt = hdata->nr_channels;
> dw->dma.max_burst = hdata->axi_rw_burst_len;
> dw->dma.src_addr_widths = AXI_DMA_BUSWIDTHS;
> dw->dma.dst_addr_widths = AXI_DMA_BUSWIDTHS;
> --
> 2.39.2

--
~Vinod