RE: [PATCH V2 2/2] ASoC: dt-bindings: max98363: add soundwire amplifier

[Lee, RyanS]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Saturday, March 11, 2023 1:10 AM
> To: “Ryan <ryan.lee.analog@xxxxxxxxx>; lgirdwood@xxxxxxxxx;
> broonie@xxxxxxxxxx; perex@xxxxxxxx; tiwai@xxxxxxxx;
> rf@xxxxxxxxxxxxxxxxxxxxx; ckeepax@xxxxxxxxxxxxxxxxxxxxx; pierre-
> louis.bossart@xxxxxxxxxxxxxxx; herve.codina@xxxxxxxxxxx;
> wangweidong.a@xxxxxxxxxx; james.schulman@xxxxxxxxxx;
> ajye_huang@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx; shumingf@xxxxxxxxxxx;
> povik+lin@xxxxxxxxxxx; flatmax@xxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> alsa-devel@xxxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; Lee, RyanS <RyanS.Lee@xxxxxxxxxx>
> Subject: Re: [PATCH V2 2/2] ASoC: dt-bindings: max98363: add soundwire
> amplifier
> 
> [External]
> 
> On 11/03/2023 02:14, “Ryan wrote:
> > From: Ryan Lee <ryans.lee@xxxxxxxxxx>
> >
> > This patch adds dt-bindings information for Analog Devices MAX98363
> > SoundWire Amplifier.
> >
> > Signed-off-by: Ryan Lee <ryans.lee@xxxxxxxxxx>
> > ---
> > Changes from v1:
> >   Fixed a syntax error for the 'dt_binding_check' build.
> >   Removed unnecessary properties.
> >   Added description about SoundWire device ID of MAX98363
> >
> >  .../bindings/sound/adi,max98363.yaml          | 42 +++++++++++++++++++
> >  1 file changed, 42 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/sound/adi,max98363.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/adi,max98363.yaml
> > b/Documentation/devicetree/bindings/sound/adi,max98363.yaml
> > new file mode 100644
> > index 000000000000..0e71b6c84007
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/adi,max98363.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> >
> +https://urldefense.com/v3/__http://devicetree.org/schemas/sound/adi,m
> >
> +ax98363.yaml*__;Iw!!A3Ni8CS0y2Y!4ewyyKINBBx1aj2efOARVpQxC3TuNeK
> Cm-K4O
> > +YvWFPfQFCpbhs6NefkJU5s0G-h625nyj5ItjNe-N4VH002-sZAucYo$
> > +$schema:
> > +https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/core.y
> > +aml*__;Iw!!A3Ni8CS0y2Y!4ewyyKINBBx1aj2efOARVpQxC3TuNeKCm-
> K4OYvWFPfQFC
> > +pbhs6NefkJU5s0G-h625nyj5ItjNe-N4VH002-Pnhea3U$
> > +
> > +title: Analog Devices MAX98363 SoundWire Amplifier
> > +
> > +maintainers:
> > +  - Ryan Lee <ryans.lee@xxxxxxxxxx>
> > +
> > +description:
> > +  The MAX98363 is a SoundWire input Class D mono amplifier that
> > +  supports MIPI SoundWire v1.2-compatible digital interface for
> > +  audio and control data.
> > +  SoundWire peripheral device ID of MAX98363 is 0x3X019F836300
> > +  where X is the peripheral device unique ID decoded from pin.
> > +  It supports up to 10 peripheral devices(0x0 to 0x9).
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,max98363
> 
> Aren't soundwire devices supposed to use device ID as compatible?

You are right. ACPI device ID is no longer valid.
I shall add the proper SoundWire device ID for the amp.
> 
> Missing blank line
> 
> > +  reg:
> > +    maxItems: 1
> > +    description: Peripheral-device unique ID decoded from pin.
> > +
> 
> It's not a DAI?

It is DAI. I suppose I need to add #sound-dai-cells' info. I shall add it.

> 
> > +required:
> > +  - compatible
> > +  - reg
> 
> Missing blank line

Thanks. I shall fix this.
> 
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    soundwire {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        amplifier@3 {
> > +            compatible = "adi,max98363";
> > +            reg = <0x3>;
> 
> That looks a bit different than regular SoundWire bus. I would argue that it's
> not SoundWire at all...

Thanks for the review. My apologies. Your statement is fair.
I shall modify the example.

> 
> 
> > +        };
> > +    };
> 
> Best regards,
> Krzysztof