Re: [PATCH v2] x86/hyperv: Mark hv_ghcb_terminate() as noreturn

From: Guilherme G. Piccoli
Date: Fri Mar 17 2023 - 12:05:41 EST


On 17/03/2023 11:53, Josh Poimboeuf wrote:
> [...]
>>> Hi Michael / Josh (and all), lemme know if you want me to submit a V3
>>> doing that. The function is not called inside this own definition file
>>> nor exported, so I'm not sure that'd be necessary, but glad to do so if
>>> you prefer.
>>>
>>
>> I don't have a preference. I was just trying to make sure the details
>> are all correct. I'll defer to those with more knowledge of the
>> __noreturn attribute than I have.
>
> It's not required, but probably good practice to put __noreturn in both
> places to make it more self-documenting.
>

Thanks Josh and Michael, will submit a V3 shortly with this improvement!
Cheers,


Guilherme