Re: [PATCH v4] firmware_loader: Add debug message with checksum for FW file

[Amadeusz Sławiński]

On 3/17/2023 3:15 PM, Greg Kroah-Hartman wrote:
> On Fri, Mar 10, 2023 at 03:04:59PM +0100, Amadeusz Sławiński wrote:
> > Enable dynamic-debug logging of firmware filenames and SHA256 checksums
> > to clearly identify the firmware files that are loaded by the system.
> >
> > Example output:
> > [   34.944619] firmware_class:_request_firmware: i915 0000:00:02.0: Loaded FW: i915/kbl_dmc_ver1_04.bin, sha256: 2cde41c3e5ad181423bcc3e98ff9c49f743c88f18646af4d0b3c3a9664b831a1
> > [   48.155884] firmware_class:_request_firmware: snd_soc_avs 0000:00:1f.3: Loaded FW: intel/avs/cnl/dsp_basefw.bin, sha256: 43f6ac1b066e9bd0423d914960fbbdccb391af27d2b1da1085eee3ea8df0f357
> > [   49.579540] firmware_class:_request_firmware: snd_soc_avs 0000:00:1f.3: Loaded FW: intel/avs/rt274-tplg.bin, sha256: 4b3580da96dc3d2c443ba20c6728d8b665fceb3ed57223c3a57582bbad8e2413
> > [   49.798196] firmware_class:_request_firmware: snd_soc_avs 0000:00:1f.3: Loaded FW: intel/avs/hda-8086280c-tplg.bin, sha256: 5653172579b2be1b51fd69f5cf46e2bac8d63f2a1327924311c13b2f1fe6e601
> > [   49.859627] firmware_class:_request_firmware: snd_soc_avs 0000:00:1f.3: Loaded FW: intel/avs/dmic-tplg.bin, sha256: 00fb7fbdb74683333400d7e46925dae60db448b88638efcca0b30215db9df63f
> >
> > Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
> > Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@xxxxxxxxxxxxxxx>
> > ---
> >
> > Changes in v4:
> >   * update menuconfig prompt and help message (Russ)
> >
> > Changes in v3:
> >   * add DYNAMIC_DEBUG and FW_LOADER as dependencies before option can be
> > enabled (kernel test robot)
> >
> > Changes in v2:
> >   * allocate buffers (Greg)
> >   * introduce CONFIG_ option to allow for CONFIG_CRYPTO and CONFIG_CRYPTO_SHA256
> > dependencies without introducing circular dependency (Greg)
> >   * add new line between includes and function name (Cezary)
> >
> > ---
> >   drivers/base/firmware_loader/Kconfig | 13 ++++++++
> >   drivers/base/firmware_loader/main.c  | 48 +++++++++++++++++++++++++++-
> >   2 files changed, 60 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/firmware_loader/Kconfig b/drivers/base/firmware_loader/Kconfig
> > index 5166b323a0f8..6520e8c9cb38 100644
> > --- a/drivers/base/firmware_loader/Kconfig
> > +++ b/drivers/base/firmware_loader/Kconfig
> > @@ -3,6 +3,7 @@ menu "Firmware loader"
> >   
> >   config FW_LOADER
> >   	tristate "Firmware loading facility" if EXPERT
> > +	select FW_LOADER_DEBUG if DYNAMIC_DEBUG
>
> Why the select?  that prevents anyone from actually choosing this if
> they want to or not.  It also prevents them from disabling this option
> if they want to, while still keeping DYNAMIC_DEBUG enabled.
>
> So please don't make this change.
Indeed it seems unnecessary, I removed it in v5.

Thanks,

Amadeusz