RE: [PATCH v2] x86/hyperv: Mark hv_ghcb_terminate() as noreturn

From: Michael Kelley (LINUX)
Date: Fri Mar 17 2023 - 09:40:53 EST


From: Guilherme G. Piccoli <gpiccoli@xxxxxxxxxx> Sent: Thursday, March 16, 2023 2:24 PM
>
> On 10/03/2023 18:17, Michael Kelley (LINUX) wrote:
> > [...]
> > Just curious: Should the actual function also be updated with
> > __noreturn? In similar situations, such as snp_abort(), the
> > __noreturn attribute is both places. I don't know what the
> > guidance is on this question.
> >
>
> Hi Michael / Josh (and all), lemme know if you want me to submit a V3
> doing that. The function is not called inside this own definition file
> nor exported, so I'm not sure that'd be necessary, but glad to do so if
> you prefer.
>

I don't have a preference. I was just trying to make sure the details
are all correct. I'll defer to those with more knowledge of the
__noreturn attribute than I have.

Michael