Re: [PATCH v2] dt-bindings: display: mediatek: Fix the duplicated fallback

[Matthias Brugger]

On 06/03/2023 17:15, Alexandre Mergnat wrote:
> The item which have the mediatek,mt8192-disp-ccorr const compatible already
> exist above. Remove duplicated fallback.
>
> Fixes: 137272ef1b0f ("dt-bindings: display: mediatek: Fix the fallback for mediatek,mt8186-disp-ccorr")

We can argue if dt-binding patches should have a fixes tag at all. Given the 
fact that there are so many warnings still around, I don't see any value add to 
backport these to stable kernel.

That said, this is defenitely no fix, as it's only a code clean-up. No warning, 
no bug, no functional error fixed here :)

> Signed-off-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx>
> ---
> Fix MTK color correction binding
>
> The fallback compatible has been duplicated in the 137272ef1b0f commit.
>
> To: Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx>
> To: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> To: David Airlie <airlied@xxxxxxxxx>
> To: Daniel Vetter <daniel@xxxxxxxx>
> To: Rob Herring <robh+dt@xxxxxxxxxx>
> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> To: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> To: Allen-KH Cheng <allen-kh.cheng@xxxxxxxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: linux-mediatek@xxxxxxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> ---
> Changes in v2:
> - Fix commit title.
> - Link to v1: https://lore.kernel.org/r/20230306-ccorr-binding-fix-v1-0-177d81d60c69@xxxxxxxxxxxx
> ---
>   Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> index b04820c95b22..3aaf44719786 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> @@ -29,9 +29,6 @@ properties:
>             - enum:
>                 - mediatek,mt8188-disp-ccorr
>                 - mediatek,mt8195-disp-ccorr
> -          - const: mediatek,mt8192-disp-ccorr
> -      - items:
> -          - enum:
>                 - mediatek,mt8186-disp-ccorr

Please sort compatibles, that will allow for easier reading once we add more to 
the file.

Regards,
Matthias

>             - const: mediatek,mt8192-disp-ccorr
>   
>
> ---
> base-commit: add072536971d7ce891fde3cdbf68c55e7cfa95a
> change-id: 20230306-ccorr-binding-fix-718c6d725088
>
> Best regards,