Re: [PATCH v2] mm/slub: fix help comment of SLUB_DEBUG

From: Vlastimil Babka
Date: Fri Mar 17 2023 - 07:04:27 EST


On 3/14/23 08:16, Vernon Yang wrote:
> Since commit ab4d5ed5eeda ("slub: Enable sysfs support for
> !CONFIG_SLUB_DEBUG"), disabling SLUB_DEBUG also disables
> SLUB sysfs support that is not true anymore, so fix it correctly.
>
> Signed-off-by: Vernon Yang <vernon2gm@xxxxxxxxx>

Thanks, slightly reworded and pushed to slab/for-6.4/trivial

> ---
> mm/Kconfig.debug | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
> index c3547a373c9c..9a90a88ce053 100644
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug
> @@ -60,9 +60,8 @@ config SLUB_DEBUG
> select STACKDEPOT if STACKTRACE_SUPPORT
> help
> SLUB has extensive debug support features. Disabling these can
> - result in significant savings in code size. This also disables
> - SLUB sysfs support. /sys/slab will not exist and there will be
> - no support for cache validation etc.
> + result in significant savings in code size, the /sys/kernel/slab
> + will exist but will not provide e.g. cache validation.
>
> config SLUB_DEBUG_ON
> bool "SLUB debugging on by default"