Re: [PATCH v2 1/2] dt-bindings: spi: add loongson spi

[zhuyinbo]

在 2023/3/17 下午5:15, Krzysztof Kozlowski 写道:
> On 17/03/2023 09:29, Yinbo Zhu wrote:
> > Add the Loongson platform spi binding with DT schema format using
> > json-schema.
> >
> > Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
> > ---
> >   .../bindings/spi/loongson,ls-spi.yaml         | 44 +++++++++++++++++++
> >   MAINTAINERS                                   |  6 +++
> >   2 files changed, 50 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml b/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml
> > new file mode 100644
> > index 000000000000..936b8dc82ce8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +
> Drop blank line above.
>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/spi/loongson,ls-spi.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Loongson SPI controller
> > +
> > +maintainers:
> > +  - Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: /schemas/spi/spi-controller.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - loongson,ls2k-spi
> > +      - loongson,ls7a-spi
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    minItems: 1
> I don't understand why did you change it. I did not ask for it.
>
> Best regards,
> Krzysztof
Add clocks "minItems: 1" description is for fix yaml file compile issue.