Re: [PATCH v2 4/4] dt-bindings: arm: hisilicon: Add Hi37xx SoCs

From: Krzysztof Kozlowski
Date: Fri Mar 17 2023 - 05:05:30 EST


On 17/03/2023 09:53, David Yang wrote:
> Add devicetree binding for Hisilicon Hi37xx SoCs.
>
> Signed-off-by: David Yang <mmyangfl@xxxxxxxxx>
> ---
> .../bindings/arm/hisilicon/hisilicon.yaml | 28 +++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.yaml b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.yaml
> index 540876322..0e0fcb1c7 100644
> --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.yaml
> +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.yaml
> @@ -25,11 +25,39 @@ properties:
> - const: hisilicon,hi3670-hikey970
> - const: hisilicon,hi3670
>
> + - description: Hi3716cv200 based boards.
> + items:
> + - const: hisilicon,hi3716cv200

None of these here are correct compatibles for boards. Board compatible
has minimum two pieces: board compatible and SoC compatible.



Best regards,
Krzysztof