Re: [PATCH 10/15] dt-bindings: serial: Document ma35d1 uart controller bindings

[Jacky Huang]

Dear Krzysztof,


Thanks for your advice.


On 2023/3/16 下午 03:40, Krzysztof Kozlowski wrote:
> On 15/03/2023 08:28, Jacky Huang wrote:
> > From: Jacky Huang <ychuang3@xxxxxxxxxxx>
> >
> > Add documentation to describe nuvoton ma35d1 uart driver bindings.
> Subject: drop second/last, redundant "bindings". The "dt-bindings"
> prefix is already stating that these are bindings.

I will fix it.

> > Signed-off-by: Jacky Huang <ychuang3@xxxxxxxxxxx>
> > ---
> >   .../serial/nuvoton,ma35d1-serial.yaml         | 52 +++++++++++++++++++
> >   1 file changed, 52 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.yaml b/Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.yaml
> > new file mode 100644
> > index 000000000000..9daa2efd4734
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/serial/nuvoton,ma35d1-serial.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Nuvoton MA35D1 Universal Asynchronous Receiver/Transmitter (UART)
> > +
> > +maintainers:
> > +  - Min-Jen Chen <mjchen@xxxxxxxxxxx>
> > +  - Jacky Huang <ychuang3@xxxxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: "serial.yaml"
> Drop quotes. Use some recent bindings as your starting point, so we do
> not have to give comments for things which were already fixed.

Got it, I will remove the quotes.

> > +
> > +properties:
> > +  compatible:
> > +    const: nuvoton,ma35d1-uart
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/clock/nuvoton,ma35d1-clk.h>
> > +
> > +    aliases {
> > +        serial0 = &uart0;
> > +    };
> Drop aliases.

I will fix it.

> > +
> > +    uart0:serial@40700000 {
> Drop label

OK, I will remove the label.

> Best regards,
> Krzysztof

Best regards,

Jacky Huang