Re: [PATCH 01/11] dt-bindings: firmware: arm,scmi: Document assigned-clocks and assigned-clock-rates

From: Sudeep Holla
Date: Thu Mar 16 2023 - 18:28:39 EST


On Thu, Mar 16, 2023 at 03:34:17PM -0500, Rob Herring wrote:
> +Stephen
>
> On Wed, Mar 15, 2023 at 01:47:56PM +0200, Cristian Ciocaltea wrote:
> > Since commit df4fdd0db475 ("dt-bindings: firmware: arm,scmi: Restrict
> > protocol child node properties") the following dtbs_check warning is
> > shown:
> >
> > rk3588-rock-5b.dtb: scmi: protocol@14: Unevaluated properties are not allowed ('assigned-clock-rates', 'assigned-clocks' were unexpected)
>
> I think that's a somewhat questionable use of assigned-clock-rates. It
> should be located with the consumer rather than the provider IMO. The
> consumers of those 2 clocks are the CPU nodes.
>

Agreed. We definitely don't use those in the scmi clk provider driver.
So NACK for the generic SCMI binding change.

--
Regards,
Sudeep