Re: [PATCH v5] staging: axis-fifo: initialize timeouts in probe only

From: Fabio M. De Francesco
Date: Thu Mar 16 2023 - 16:17:59 EST


On giovedì 16 marzo 2023 19:35:09 CET Khadija Kamran wrote:
> On Thu, Mar 16, 2023 at 05:17:47PM +0100, Fabio M. De Francesco wrote:

[snip]

> > When you are done with build, install, and final reboot to test if your
> > module can "modprobe" or "insmod" (i.e. link with the running custom
kernel
> > you built, installed and boot), try to compare the output of the following
> > commands:
> >
> > # uname -a
> > Linux suse 6.2.2-1-default #1 SMP PREEMPT_DYNAMIC Thu Mar 9 06:06:13 UTC
> > 2023 (44ca817) x86_64 x86_64 x86_64 GNU/Linux
>
> The above command works
>
> > AND
> >
> > # modinfo <name of the module you are testing here>
>
> On running 'modinfo axis-fifo' I get error saying module axis-fifo not
> found.

I built axis-fifo with your changes and then I ran "make install
modules_install" in a QEMU/KVM x86_32 VM that I use on a Linux host for
testing my patches (Linux on Linux).

tweed32:~ # uname -a
Linux tweed32 6.3.0-rc2-x86-32-debug+ #32 SMP PREEMPT_DYNAMIC Thu Mar 16
18:09:49 CET 2023 i686 athlon i386 GNU/Linux

tweed32:~ # modinfo axis-fifo
filename: /lib/modules/6.3.0-rc2-x86-32-debug+/kernel/drivers/staging/
axis-fifo/axis-fifo.ko
description: Xilinx AXI-Stream FIFO v4.1 IP core driver
author: Jacob Feder <jacobsfeder@xxxxxxxxx>
license: GPL
srcversion: EBF46AD6851EAAE67D1000B
alias: of:N*T*Cxlnx,axi-fifo-mm-s-4.1C*
alias: of:N*T*Cxlnx,axi-fifo-mm-s-4.1
depends:
staging: Y
retpoline: Y
intree: Y
name: axis_fifo
vermagic: 6.3.0-rc2-x86-32-debug+ SMP preempt mod_unload modversions K7
parm: read_timeout:ms to wait before blocking read() timing out; set
to -1 for no timeout (long)
parm: write_timeout:ms to wait before blocking write() timing out;
set to -1 for no timeout (long)

Do you see the "parm" lines? What's the type of read and write_timeout?

Fabio