Re: [PATCH net v2 2/2] sh_eth: avoid PHY being resumed when interface is not up

From: Sergey Shtylyov
Date: Thu Mar 16 2023 - 16:00:51 EST


On 3/15/23 10:41 AM, Wolfram Sang wrote:

> SH_ETH doesn't need mdiobus suspend/resume, that's why it sets
> 'mac_managed_pm'. However, setting it needs to be moved from init to
> probe, so mdiobus PM functions will really never be called (e.g. when
> the interface is not up yet during suspend/resume).
>
> Fixes: 6a1dbfefdae4 ("net: sh_eth: Fix PHY state warning splat during system resume")
> Suggested-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Michal Kubiak <michal.kubiak@xxxxxxxxx>

[...]

Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>

MBR, Sergey