Re: [PATCH v3 4/8] platform/x86/intel/ifs: Introduce Array Scan test to IFS

From: Joseph, Jithu
Date: Thu Mar 16 2023 - 15:44:21 EST




On 3/16/2023 2:50 AM, Hans de Goede wrote:

> Ok I see, lets go with 1 intel_ifs device per test-type then.
>
> If I understood things correctly esp. also with the /lib/firmware path then the <N> in intel_ifs_<N> basically specifies the test-type, correct ?
>

Correct

> If I have that correct please add this to the ABI documentation in the form of a list with
>
> intel_ifs_<N> <-> test-type
>
> mappings. And also add documentation to each attribute for which test-types the attribute is valid (this can be "all" for e.g. status, to avoid churn when adding more test types).

Will do. Thanks for the review comments

Jithu