Re: [PATCH v2 1/9] coresight: Use enum type for cs_mode wherever possible

[Suzuki K Poulose]

On 10/03/2023 16:06, James Clark wrote:
> mode is stored as a local_t, but it is also passed around a lot as a
> plain u32, so use the correct type wherever local_t isn't currently
> used. This helps a little bit with readability.
>
> Signed-off-by: James Clark <james.clark@xxxxxxx>
> ---
>   drivers/hwtracing/coresight/coresight-core.c       |  7 ++++---
>   drivers/hwtracing/coresight/coresight-etb10.c      |  3 ++-
>   drivers/hwtracing/coresight/coresight-etm3x-core.c |  6 +++---
>   drivers/hwtracing/coresight/coresight-etm4x-core.c |  6 +++---
>   drivers/hwtracing/coresight/coresight-priv.h       |  9 ++-------
>   drivers/hwtracing/coresight/coresight-stm.c        |  6 +++---
>   drivers/hwtracing/coresight/coresight-tmc-etf.c    |  2 +-
>   drivers/hwtracing/coresight/coresight-tmc-etr.c    |  7 +++----
>   drivers/hwtracing/coresight/coresight-tpdm.c       |  4 ++--
>   drivers/hwtracing/coresight/coresight-tpiu.c       |  3 ++-
>   drivers/hwtracing/coresight/coresight-trbe.c       |  3 ++-
>   drivers/hwtracing/coresight/ultrasoc-smb.c         |  3 ++-
>   drivers/hwtracing/coresight/ultrasoc-smb.h         |  2 +-
>   include/linux/coresight.h                          | 13 ++++++++++---
>   14 files changed, 40 insertions(+), 34 deletions(-)

Looks good to me.

Suzuki