Re: [RFC PATCH 27/28] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage

From: David Howells
Date: Thu Mar 16 2023 - 12:25:47 EST


Trond Myklebust <trondmy@xxxxxxxxxxxxxxx> wrote:

> > + buf->bvec += 2;
> > + buf->bvec[-2].bv_page = NULL;
> > + buf->bvec[-1].bv_page = NULL;
>
> NACK.

Can you elaborate?

Is it that you dislike allocating extra slots for protocol bits? Or just that
the bvec[] is offset by 2? Or some other reason?

David