Re: [PATCH] platform/x86: think-lmi: Properly interpret return value of tlmi_setting

[Hans de Goede]

Hi,

On 3/12/23 04:47, Thomas Weißschuh wrote:
> The return value of tlmi_settings() is an errorcode, not an acpi_status.
> 
> Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
> 
> Note: This is only compile-tested.
> ---
>  drivers/platform/x86/think-lmi.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c
> index 86b33b74519b..c924e9e4a6a5 100644
> --- a/drivers/platform/x86/think-lmi.c
> +++ b/drivers/platform/x86/think-lmi.c
> @@ -1353,7 +1353,6 @@ static struct tlmi_pwd_setting *tlmi_create_auth(const char *pwd_type,
>  
>  static int tlmi_analyze(void)
>  {
> -	acpi_status status;
>  	int i, ret;
>  
>  	if (wmi_has_guid(LENOVO_SET_BIOS_SETTINGS_GUID) &&
> @@ -1390,8 +1389,8 @@ static int tlmi_analyze(void)
>  		char *p;
>  
>  		tlmi_priv.setting[i] = NULL;
> -		status = tlmi_setting(i, &item, LENOVO_BIOS_SETTING_GUID);
> -		if (ACPI_FAILURE(status))
> +		ret = tlmi_setting(i, &item, LENOVO_BIOS_SETTING_GUID);
> +		if (ret)
>  			break;
>  		if (!item)
>  			break;
> 
> ---
> base-commit: 81ff855485a366a391dc3aed3942715e676ed132
> change-id: 20230312-think-lmi-status-0d76cbe1b7d9
> 
> Best regards,