Re: [PATCH v1 1/1] regulator: s5m8767: Replace of_gpio.h with what indeed is used

From: Mark Brown
Date: Thu Mar 16 2023 - 09:10:57 EST


On Thu, Mar 16, 2023 at 02:01:13PM +0200, Andy Shevchenko wrote:
> of_gpio.h in this driver is solely used as a proxy to other headers.
> This is incorrect usage of the of_gpio.h. Replace it .h with what
> indeed is used in the code.

This breaks an x86 allmodconfig build:

/build/stage/linux/drivers/regulator/s5m8767.c: In function ‘s5m8767_pmic_dt_parse_dvs_gpio’:
/build/stage/linux/drivers/regulator/s5m8767.c:492:24: error: implicit declaration of function ‘of_get_named_gpio’ [-Werror=implicit-function-declaration]
492 | gpio = of_get_named_gpio(pmic_np,
| ^~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Attachment: signature.asc
Description: PGP signature