Re: [PATCH v1] Bluetooth: mgmt: Fix MGMT add advmon with RSSI command

[Paul Menzel]

Dear Howard,


Thank you for your patch.

Am 16.03.23 um 08:10 schrieb Howard Chung:
> From: howardchung <howardchung@xxxxxxxxxx>

Please configure your full name:

    git config --global user.name "Howard Chung"
    git commit -s --amend --author="Howard Chung <howardchung@xxxxxxxxxx>"

> The MGMT command: MGMT_OP_ADD_ADV_PATTERNS_MONITOR_RSSI uses variable
> length argumenent. This patch adds right the field.

argument

Were you seeing actual problems? If so, please describe the test setup.

> Reviewed-by: Archie Pusaka <apusaka@xxxxxxxxxxxx>
> Fixes: b338d91703fa ("Bluetooth: Implement support for Mesh")
> Signed-off-by: howardchung <howardchung@xxxxxxxxxx>
> ---
>
>   net/bluetooth/mgmt.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 39589f864ea7..249dc6777fb4 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -9357,7 +9357,8 @@ static const struct hci_mgmt_handler mgmt_handlers[] = {
>   	{ add_ext_adv_data,        MGMT_ADD_EXT_ADV_DATA_SIZE,
>   						HCI_MGMT_VAR_LEN },
>   	{ add_adv_patterns_monitor_rssi,
> -				   MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE },
> +				   MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE,
> +						HCI_MGMT_VAR_LEN },
>   	{ set_mesh,                MGMT_SET_MESH_RECEIVER_SIZE,
>   						HCI_MGMT_VAR_LEN },
>   	{ mesh_features,           MGMT_MESH_READ_FEATURES_SIZE },

Acked-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>


Kind regards,

Paul